Migrate (some) of run-pass/ to ui #53860

pnkfelix · 2018-08-31T15:35:59Z

This is a step towards addressing #53764. Much still remains.

I went through a large portion of the *.rs files that were directly stored into src/test/run-pass/ and moved them into various subdirectories of a newly created src/test/ui/run-pass/.

(yes, it would have perhaps been nice to meld it more directly with directories already in src/test/ui/; but the sad truth is that opens up the reality of filename collisions, and one of my short term goals for resolving #53764 is to keep the filenames invariant, even as their parents directories and contents are mildly revised...)

rust-highfive · 2018-08-31T15:36:11Z

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

pnkfelix · 2018-08-31T15:36:17Z

r? @nikomatsakis

nikomatsakis · 2018-08-31T17:57:04Z

@bors r+

cc @rust-lang/compiler — seems like a notable change.

petrochenkov · 2018-08-31T18:22:05Z

The directory collapsing part looks questionable to me.
As a user of hygiene/, imports/, macros/, etc, I can say that they are all useful and different, and this PR makes things worse for me specifically + these directory rearrangements are not entirely on-topic for this PR.
I'd prefer to leave directory grouping to people writing/maintaining specific groups of tests (or at least to come up with some convention document before making changes).

nikomatsakis · 2018-08-31T18:39:09Z

@bors r-

nikomatsakis · 2018-08-31T18:39:57Z

@petrochenkov

As a user of hygiene/, imports/, macros/, etc, I can say that they are all useful and different, and this PR makes things worse for me specifically + these directory rearrangements are not entirely on-topic for this PR.

I'm confused, perhaps. I thought that this PR preserved the existing run-pass directory structure, but made it a subpart of src/test/ui?

nikomatsakis · 2018-08-31T18:40:17Z

Ah, I see, I missed the various "collapse" commits.

pnkfelix · 2018-09-01T21:25:59Z

Hmm I thought my collapsing cases here still didn't destroy anything distinctions that were previously there.

That is, the directories being collapsed were ones that I created in earlier commits in the PR, and the source material ... always came solely from src/test/run-pass/*.rs, and none of its subdirectories .... (right? Or did I misremember and/or screw up somewhere?)

Having said that, I'm happy to drop some/all/any of the collapsing commits.

Update: at the very least, I misremembered, in that I did port over some directory structure. And its certainly possible that I subsequently collapsed them when I shouldn't have. So I can just kill off those commits.

pnkfelix · 2018-09-03T08:29:55Z

@bors r=nikomatsakis

pnkfelix · 2018-09-03T09:44:38Z

@bors ping

pietroalbini · 2018-09-03T09:52:56Z

@bors are you still there?

bors · 2018-09-03T09:52:57Z

🍰 Target acquired

pnkfelix · 2018-09-03T09:55:27Z

@bors r=nikomatsakis

bors · 2018-09-03T09:55:27Z

📌 Commit 74a5aef has been approved by nikomatsakis

bors · 2018-09-03T20:07:20Z

⌛ Testing commit 74a5aef with merge eb74017...

…=nikomatsakis Migrate (some) of run-pass/ to ui This is a step towards addressing #53764. Much still remains. I went through a large portion of the `*.rs` files that were directly stored into `src/test/run-pass/` and moved them into various subdirectories of a newly created `src/test/ui/run-pass/`. (yes, it would have perhaps been nice to meld it more directly with directories already in `src/test/ui/`; but the sad truth is that opens up the reality of filename collisions, and one of my short term goals for resolving #53764 is to keep the *filenames* invariant, even as their parents directories and contents are mildly revised...)

bors · 2018-09-03T20:59:04Z

💔 Test failed - status-appveyor

kennytm · 2018-09-04T02:47:14Z

Several these new UI tests generate integer overflow warnings on 32-bit platform e.g.

---- [ui] ui\run-pass\structs-enums\enum-discrim-width-stuff.rs stdout ----
normalized stderr:
warning: literal out of range for isize
  --> $DIR/enum-discrim-width-stuff.rs:40:20
   |
LL |     check!(f, u32, 0xe8d8c8b8);
   |                    ^^^^^^^^^^
   |
   = note: #[warn(overflowing_literals)] on by default
   = note: the literal `0xe8d8c8b8` (decimal `3906521272`) does not fit into an `isize` and will become `-388446024isize`

List of failures:

failures:
    [ui] ui\run-pass\array-slice-vec\box-of-array-of-drop-1.rs
    [ui] ui\run-pass\array-slice-vec\box-of-array-of-drop-2.rs
    [ui] ui\run-pass\array-slice-vec\nested-vec-3.rs
    [ui] ui\run-pass\consts\const-fn-val.rs
    [ui] ui\run-pass\deriving\deriving-hash.rs
    [ui] ui\run-pass\simd\simd-target-feature-mixup.rs
    [ui] ui\run-pass\structs-enums\enum-discrim-autosizing.rs
    [ui] ui\run-pass\structs-enums\enum-discrim-width-stuff.rs

(I may have accidentally added it to some auxilliary crates as well; my emacs-macro-based methodology was pretty crude.)

…o silence stderr output.

…(C)`. See also rust-lang#53858.

…est seems bogus. that is, I suspect it should be retired because it is testing behavior (namely a `#[repr(C)] struct Empty;`) that, if I understand correctly, is undefined. See also rust-lang#53859.

See rust-lang#53857.

…ced).

…s to test such cases.

…pdated at some point. Discussion can be found on rust-lang#41620.

…d to `#[may_dangle]`. See rust-lang#34761.

…t be silenced.

That is, opting to ignore stable `#![feature(..)]`, under my theory that a reviewer would prefer as much stuff to be bucketed under "ah another `#![allow(..)]` here." as possible.

…se on 32-bit.

pnkfelix · 2018-09-06T11:28:20Z

@bors r=nikomatsakis

bors · 2018-09-06T11:28:21Z

📌 Commit 5fe0851 has been approved by nikomatsakis

…ss-to-ui, r=nikomatsakis Migrate (some) of run-pass/ to ui This is a step towards addressing rust-lang#53764. Much still remains. I went through a large portion of the `*.rs` files that were directly stored into `src/test/run-pass/` and moved them into various subdirectories of a newly created `src/test/ui/run-pass/`. (yes, it would have perhaps been nice to meld it more directly with directories already in `src/test/ui/`; but the sad truth is that opens up the reality of filename collisions, and one of my short term goals for resolving rust-lang#53764 is to keep the *filenames* invariant, even as their parents directories and contents are mildly revised...)

Rollup of 17 pull requests Successful merges: - #53299 (Updated core/macros.rs to note it works in a no_std environment.) - #53376 (Cross reference io::copy and fs::copy in docs.) - #53455 (Individual docs for {from,to}_*_bytes) - #53550 (librustc_lint: In recursion warning, change 'recurring' to 'recursing') - #53860 (Migrate (some) of run-pass/ to ui) - #53874 (Implement Unpin for Box, Rc, and Arc) - #53895 (tidy: Cleanups and clippy warning fixes) - #53946 (Clarify `ManuallyDrop` docs) - #53948 (Minimized clippy test from when NLL disabled two-phase borrows) - #53959 (Add .git extension to submodule paths missing it) - #53966 (A few cleanups and minor improvements to mir/dataflow) - #53967 (propagate build.python into cmake) - #53979 (Remove `#[repr(transparent)]` from atomics) - #53991 (Add unchecked_shl/shr check for intrinsics to fix miri's test suit) - #53992 (migrate run-pass/borrowck to ui/run-pass) - #53994 (migrate run-pass/*/ to ui/run-pass) - #54023 (update clippy submodule)

rust-highfive assigned alexcrichton Aug 31, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 31, 2018

rust-highfive assigned nikomatsakis and unassigned alexcrichton Aug 31, 2018

pnkfelix force-pushed the issue-53764-migrate-run-pass-to-ui branch 2 times, most recently from 1d01152 to 74a5aef Compare September 3, 2018 08:27

pnkfelix added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 3, 2018

pietroalbini closed this Sep 3, 2018

pietroalbini reopened this Sep 3, 2018

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 3, 2018

pnkfelix added 16 commits September 6, 2018 13:00

Add // run-pass annotations to all the tests under ui/run-pass/.

0909e0b

(I may have accidentally added it to some auxilliary crates as well; my emacs-macro-based methodology was pretty crude.)

Move a bunch of auxiliary support files into ui/run-pass/**/auxiliary.

06f36a0

Remove references to a collection of unknown lints.

90241df

Add #![allow(..)] for a slew of lints of migrated run-pass tests, t…

e462c1a

…o silence stderr output.

Add #[allow(improper_ctypes)] to slew of cases that need e.g. `repr…

8bcf37d

…(C)`. See also rust-lang#53858.

Add #![allow(improper_ctypes)] to extern-pass-empty.rs; note this t…

d18b3bf

…est seems bogus. that is, I suspect it should be retired because it is testing behavior (namely a `#[repr(C)] struct Empty;`) that, if I understand correctly, is undefined. See also rust-lang#53859.

Add .stderr file for test where there are conflicting repr hints.

175d7f4

See rust-lang#53857.

Alpha-rename label to avoid the shadowing lint (which cannot be silen…

f78b9ad

…ced).

Add .stderr files for shadowed labels where the point of the test i…

90412f1

…s to test such cases.

Update line numbers to reflect added lines at beginning of tests.

dc7685e

Allow illegal_floating_point_literal_pattern. These will need to be u…

4a9e55e

…pdated at some point. Discussion can be found on rust-lang#41620.

Allow uses of #[unsafe_destructor_blind_to_params]. Should be porte…

18a77ae

…d to `#[may_dangle]`. See rust-lang#34761.

Add .stdout file for test of log_syntax! and trace_macros!.

2bce9b0

Add .stderr file for test that appears to trigger a lint that canno…

f97eea1

…t be silenced.

Add #![allow(stable_features)] to ease review.

dc124e4

That is, opting to ignore stable `#![feature(..)]`, under my theory that a reviewer would prefer as much stuff to be bucketed under "ah another `#![allow(..)]` here." as possible.

Allow more lints, mainly overflowing_literals for cases that only aro…

5fe0851

…se on 32-bit.

pnkfelix force-pushed the issue-53764-migrate-run-pass-to-ui branch from 433032b to 5fe0851 Compare September 6, 2018 11:27

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 6, 2018

pnkfelix mentioned this pull request Sep 6, 2018

NLL: need to run the run-pass tests under compare-mode=nll #53764

Closed

43 tasks

kennytm mentioned this pull request Sep 7, 2018

Rollup of 17 pull requests #54021

Merged

bors merged commit 5fe0851 into rust-lang:master Sep 7, 2018

petrochenkov mentioned this pull request Sep 8, 2018

Implement some way to run UI tests ignoring run-pass tests #54047

Closed

Migrate (some) of run-pass/ to ui #53860

Migrate (some) of run-pass/ to ui #53860

Uh oh!

Conversation

pnkfelix commented Aug 31, 2018

Uh oh!

rust-highfive commented Aug 31, 2018

Uh oh!

pnkfelix commented Aug 31, 2018

Uh oh!

nikomatsakis commented Aug 31, 2018

Uh oh!

petrochenkov commented Aug 31, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nikomatsakis commented Aug 31, 2018

Uh oh!

nikomatsakis commented Aug 31, 2018

Uh oh!

nikomatsakis commented Aug 31, 2018

Uh oh!

pnkfelix commented Sep 1, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pnkfelix commented Sep 3, 2018

Uh oh!

pnkfelix commented Sep 3, 2018

Uh oh!

pietroalbini commented Sep 3, 2018

Uh oh!

bors commented Sep 3, 2018

Uh oh!

pnkfelix commented Sep 3, 2018

Uh oh!

bors commented Sep 3, 2018

Uh oh!

bors commented Sep 3, 2018

Uh oh!

bors commented Sep 3, 2018

Uh oh!

kennytm commented Sep 4, 2018

Uh oh!

pnkfelix commented Sep 6, 2018

Uh oh!

bors commented Sep 6, 2018

Uh oh!

Uh oh!

petrochenkov commented Aug 31, 2018 •

edited

Loading

pnkfelix commented Sep 1, 2018 •

edited

Loading